Skip to content

Fix flaky test: ESM module loading race condition in test_subcomponent_notation #1315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Archmonger merged 5 commits into from
Dec 12, 2025
Merged

Fix flaky test: ESM module loading race condition in test_subcomponent_notation #1315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f2f7736
Initial plan
Copilot Dec 12, 2025
6c58bd1
Fix flaky test by pinning esm.sh version and importing react-is
Copilot Dec 12, 2025
4fa2c3b
Add changelog entry for flaky test fix
Copilot Dec 12, 2025
4d6111d
Add explanatory comments for ReactIs import
Copilot Dec 12, 2025
6340bb5
Remove changelog entry
Archmonger Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions tests/test_reactjs/js_fixtures/subcomponent-notation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
import React from "https://esm.sh/react@19.0"
import ReactDOM from "https://esm.sh/react-dom@19.0/client"
import {InputGroup, Form} from "https://esm.sh/react-bootstrap@2.10.2?deps=react@19.0,react-dom@19.0,react-is@19.0&exports=InputGroup,Form";
import React from "https://esm.sh/v135/react@19.0"
import ReactDOM from "https://esm.sh/v135/react-dom@19.0/client"
// Explicitly import react-is to ensure it's loaded before react-bootstrap
// This prevents race conditions where react-bootstrap tries to use React context before deps are ready
import * as ReactIs from "https://esm.sh/v135/react-is@19.0"
import {InputGroup, Form} from "https://esm.sh/v135/react-bootstrap@2.10.2?deps=react@19.0,react-dom@19.0,react-is@19.0&exports=InputGroup,Form";
export {InputGroup, Form};

export function bind(node, config) {
Expand Down
9 changes: 6 additions & 3 deletions tests/test_web/js_fixtures/subcomponent-notation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
import React from "https://esm.sh/react@19.0"
import ReactDOM from "https://esm.sh/react-dom@19.0/client"
import {InputGroup, Form} from "https://esm.sh/react-bootstrap@2.10.2?deps=react@19.0,react-dom@19.0,react-is@19.0&exports=InputGroup,Form";
import React from "https://esm.sh/v135/react@19.0"
import ReactDOM from "https://esm.sh/v135/react-dom@19.0/client"
// Explicitly import react-is to ensure it's loaded before react-bootstrap
// This prevents race conditions where react-bootstrap tries to use React context before deps are ready
import * as ReactIs from "https://esm.sh/v135/react-is@19.0"
import {InputGroup, Form} from "https://esm.sh/v135/react-bootstrap@2.10.2?deps=react@19.0,react-dom@19.0,react-is@19.0&exports=InputGroup,Form";
export {InputGroup, Form};

export function bind(node, config) {
Expand Down
Loading