-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Support set the data point color for doughnut, pie and 3D pie chart #1742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
xuri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your pull request. Unfortunately, there is no plan to add this feature. To keep the library core and easy, and follow the "typically one right way to do most things" principles, anyone can easily make a custom function to get any sheet name by themselves: active sheet name, first sheet name, last sheet name, etc., so I don't suggest adding these functions.
|
ok~ |
- Support set the data point color for doughnut, pie and 3D pie chart - Add new ChartDataPoint data type - Add new field DataPoint in the ChartSeries data type - Automating dependabot tasks with GitHub Actions - Upgrade GitHub Action tool chains version
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1742 +/- ##
=======================================
Coverage 99.47% 99.47%
=======================================
Files 32 32
Lines 25696 25704 +8
=======================================
+ Hits 25561 25569 +8
Misses 72 72
Partials 63 63
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xuri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added data point color for doughnut, pie and 3D pie chart support based on this branch.
- Add new field DataPoint in the ChartSeries data type (qax-os/excelize#1742)
PR Details
Description
add
GetActiveSheetNamefunction to easily get active sheet name.Related Issue
#1741
Motivation and Context
How Has This Been Tested
Unit test.
Types of changes
Checklist