Skip to content

Conversation

@yasarluo
Copy link
Contributor

@yasarluo yasarluo commented Dec 4, 2023

PR Details

Description

add GetActiveSheetName function to easily get active sheet name.

Related Issue

#1741

Motivation and Context

How Has This Been Tested

Unit test.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pull request. Unfortunately, there is no plan to add this feature. To keep the library core and easy, and follow the "typically one right way to do most things" principles, anyone can easily make a custom function to get any sheet name by themselves: active sheet name, first sheet name, last sheet name, etc., so I don't suggest adding these functions.

@xuri xuri added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 5, 2023
@yasarluo
Copy link
Contributor Author

yasarluo commented Dec 5, 2023

ok~

@xuri xuri closed this Jan 9, 2024
xuri added 2 commits November 25, 2025 14:25
- Support set the data point color for doughnut, pie and 3D pie chart
- Add new ChartDataPoint data type
- Add new field DataPoint in the ChartSeries data type
- Automating dependabot tasks with GitHub Actions
- Upgrade GitHub Action tool chains version
@xuri xuri reopened this Nov 25, 2025
@xuri xuri added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 25, 2025
@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.47%. Comparing base (97fd800) to head (5908f68).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1742   +/-   ##
=======================================
  Coverage   99.47%   99.47%           
=======================================
  Files          32       32           
  Lines       25696    25704    +8     
=======================================
+ Hits        25561    25569    +8     
  Misses         72       72           
  Partials       63       63           
Flag Coverage Δ
unittests 99.47% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xuri xuri changed the title #1741 add get active sheet name function Support set the data point color for doughnut, pie and 3D pie chart Nov 26, 2025
Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added data point color for doughnut, pie and 3D pie chart support based on this branch.

@xuri xuri merged commit 8a99deb into qax-os:master Nov 26, 2025
28 of 29 checks passed
@xuri xuri moved this to Features in Excelize v2.10.1 Nov 26, 2025
xuri added a commit to xuri/excelize-doc that referenced this pull request Nov 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

Status: Features

Development

Successfully merging this pull request may close these issues.

2 participants