-
Notifications
You must be signed in to change notification settings - Fork 767
Add buck target for dw conv dep #16369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Differential Revision: D89679523
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16369
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ You can merge normally! (1 Unrelated Failure)As of commit 543445f with merge base 0ee2f49 ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@digantdesai has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89679523. |
This PR needs a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a Buck build target for a Python module containing a depthwise convolution test class that is shared across multiple test files. The change enables proper dependency management for the DWConvsModule class which is imported by other test files.
- Creates a new TARGETS file defining a python_library target for the dw_convs_shared_weights module
- Adds the new target as a dependency in the test build configuration to make it available to all ARM backend tests
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| backends/arm/test/misc/TARGETS | New Buck target file defining the dw_convs_shared_weights_module python_library target with appropriate dependencies |
| backends/arm/test/targets.bzl | Adds the new module as a dependency for all ARM backend tests defined in the test suite |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Differential Revision: D89679523