Skip to content

Conversation

@digantdesai
Copy link
Contributor

Differential Revision: D89679523

Differential Revision: D89679523
Copilot AI review requested due to automatic review settings December 22, 2025 20:46
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 22, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16369

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (1 Unrelated Failure)

As of commit 543445f with merge base 0ee2f49 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 22, 2025
@meta-codesync
Copy link

meta-codesync bot commented Dec 22, 2025

@digantdesai has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89679523.

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a Buck build target for a Python module containing a depthwise convolution test class that is shared across multiple test files. The change enables proper dependency management for the DWConvsModule class which is imported by other test files.

  • Creates a new TARGETS file defining a python_library target for the dw_convs_shared_weights module
  • Adds the new target as a dependency in the test build configuration to make it available to all ARM backend tests

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
backends/arm/test/misc/TARGETS New Buck target file defining the dw_convs_shared_weights_module python_library target with appropriate dependencies
backends/arm/test/targets.bzl Adds the new module as a dependency for all ARM backend tests defined in the test suite

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@meta-codesync meta-codesync bot merged commit 7a51dd4 into pytorch:main Dec 23, 2025
150 of 166 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants