Skip to content

Conversation

@RahulC7
Copy link
Contributor

@RahulC7 RahulC7 commented Dec 22, 2025

Summary: As title. Note in the next diff, we finish off testing this, we don't test all the patterns in this diff, because some changes need to be made.

Reviewed By: hsharma35

Differential Revision: D88899457

Summary: Add annotation tests for CadenceWith16BitConvActivationsQuantizer covering both conv1d and conv2d operations.

Differential Revision: D88895865
Differential Revision: D88896712
Differential Revision: D88898823
Differential Revision: D88898933
Summary: As title. Note in the next diff, we finish off testing this, we don't test all the patterns in this diff, because some changes need to be made.

Reviewed By: hsharma35

Differential Revision: D88899457
Copilot AI review requested due to automatic review settings December 22, 2025 17:47
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 22, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16364

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job, 1 Unrelated Failure

As of commit 3bd2b6a with merge base 050e2ee (image):

CANCELLED JOB - The following job was cancelled. Please retry:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 22, 2025
@meta-codesync
Copy link

meta-codesync bot commented Dec 22, 2025

@RahulC7 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88899457.

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive test coverage for CadenceDefaultQuantizer and several other previously untested quantizers, removing them from the EXCLUDED_FROM_ANNOTATION_TESTING set.

Key changes:

  • Adds 10 new test cases covering CadenceDefaultQuantizer operations (matmul, linear, conv1d, conv2d, bmm, relu) and other quantizers (softmax, layer_norm, add)
  • Removes 5 quantizers from the exclusion list: CadenceDefaultQuantizer, CadenceWakeWordQuantizer, CadenceWith16BitConvActivationsQuantizer, CadenceWithLayerNormQuantizer, and CadenceWithSoftmaxQuantizer
  • Implements 7 new graph builder helper methods to support the new test cases

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants