-
Notifications
You must be signed in to change notification settings - Fork 766
Adding Tests for CadenceDefaultQuantizer #16364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary: Add annotation tests for CadenceWith16BitConvActivationsQuantizer covering both conv1d and conv2d operations. Differential Revision: D88895865
Differential Revision: D88896712
Differential Revision: D88898823
Differential Revision: D88898933
Summary: As title. Note in the next diff, we finish off testing this, we don't test all the patterns in this diff, because some changes need to be made. Reviewed By: hsharma35 Differential Revision: D88899457
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16364
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled Job, 1 Unrelated FailureAs of commit 3bd2b6a with merge base 050e2ee ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds comprehensive test coverage for CadenceDefaultQuantizer and several other previously untested quantizers, removing them from the EXCLUDED_FROM_ANNOTATION_TESTING set.
Key changes:
- Adds 10 new test cases covering
CadenceDefaultQuantizeroperations (matmul, linear, conv1d, conv2d, bmm, relu) and other quantizers (softmax, layer_norm, add) - Removes 5 quantizers from the exclusion list:
CadenceDefaultQuantizer,CadenceWakeWordQuantizer,CadenceWith16BitConvActivationsQuantizer,CadenceWithLayerNormQuantizer, andCadenceWithSoftmaxQuantizer - Implements 7 new graph builder helper methods to support the new test cases
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary: As title. Note in the next diff, we finish off testing this, we don't test all the patterns in this diff, because some changes need to be made.
Reviewed By: hsharma35
Differential Revision: D88899457