Add aoti_torch_item_bool and aoti_torch_assign_tensors_out shims #16345
+615
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16345
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Unrelated FailureAs of commit d5c53ec with merge base 0f5a252 ( NEW FAILURES - The following jobs have failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
larryliu0820
added a commit
that referenced
this pull request
Dec 19, 2025
Add two new shim implementations for the CUDA AOTI backend: 1. aoti_torch_item_bool: Extracts a boolean value from a 0D boolean tensor. Handles both CPU and CUDA tensors by using cudaPointerGetAttributes to determine the memory location and copying from device if needed. 2. aoti_torch_assign_tensors_out: Creates a new tensor view that shares the same underlying data as the source tensor. The new tensor has the same shape, strides, and dtype as the source. Also adds: - Declaration of aoti_torch_dtype_bool() in common_shims.h - Unit tests for both new functions - Update CMakeLists.txt with new test targets - Update targets.bzl with new test targets ghstack-source-id: de89b09 ghstack-comment-id: 3676249127 Pull-Request: #16345
This was referenced Dec 19, 2025
meta-cla
bot
added
the
CLA Signed
larryliu0820
added a commit
that referenced
this pull request
Dec 22, 2025
Add two new shim implementations for the CUDA AOTI backend: 1. aoti_torch_item_bool: Extracts a boolean value from a 0D boolean tensor. Handles both CPU and CUDA tensors by using cudaPointerGetAttributes to determine the memory location and copying from device if needed. 2. aoti_torch_assign_tensors_out: Creates a new tensor view that shares the same underlying data as the source tensor. The new tensor has the same shape, strides, and dtype as the source. Also adds: - Declaration of aoti_torch_dtype_bool() in common_shims.h - Unit tests for both new functions - Update CMakeLists.txt with new test targets - Update targets.bzl with new test targets ghstack-source-id: 4aaf6d8 ghstack-comment-id: 3676249127 Pull-Request: #16345
larryliu0820
added a commit
that referenced
this pull request
Dec 22, 2025
Add two new shim implementations for the CUDA AOTI backend: 1. aoti_torch_item_bool: Extracts a boolean value from a 0D boolean tensor. Handles both CPU and CUDA tensors by using cudaPointerGetAttributes to determine the memory location and copying from device if needed. 2. aoti_torch_assign_tensors_out: Creates a new tensor view that shares the same underlying data as the source tensor. The new tensor has the same shape, strides, and dtype as the source. Also adds: - Declaration of aoti_torch_dtype_bool() in common_shims.h - Unit tests for both new functions - Update CMakeLists.txt with new test targets - Update targets.bzl with new test targets ghstack-source-id: 74b9474 ghstack-comment-id: 3676249127 Pull-Request: #16345
larryliu0820
added a commit
that referenced
this pull request
Dec 22, 2025
Add two new shim implementations for the CUDA AOTI backend: 1. aoti_torch_item_bool: Extracts a boolean value from a 0D boolean tensor. Handles both CPU and CUDA tensors by using cudaPointerGetAttributes to determine the memory location and copying from device if needed. 2. aoti_torch_assign_tensors_out: Creates a new tensor view that shares the same underlying data as the source tensor. The new tensor has the same shape, strides, and dtype as the source. Also adds: - Declaration of aoti_torch_dtype_bool() in common_shims.h - Unit tests for both new functions - Update CMakeLists.txt with new test targets - Update targets.bzl with new test targets ghstack-source-id: 845c6fa ghstack-comment-id: 3676249127 Pull-Request: #16345
This PR needs a
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two new shim implementations for the CUDA AOTI backend:
aoti_torch_item_bool: Extracts a boolean value from a 0D boolean tensor.
Handles both CPU and CUDA tensors by using cudaPointerGetAttributes to
determine the memory location and copying from device if needed.
aoti_torch_assign_tensors_out: Creates a new tensor view that shares the
same underlying data as the source tensor. The new tensor has the same
shape, strides, and dtype as the source.
Also adds: