Implemented the loader for eIQ Neutron SDK converter. #16334
+13
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16334
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit d93861d with merge base cf28248 ( NEW FAILURE - The following job has failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Collaborator
MartinPavella
left a comment
MartinPavella
left a comment
There was a problem hiding this comment.
Please update the name of the commit to start with "NXP backend: "
| requested_module_name = f"neutron_converter_{neutron_converter_flavor}" | ||
| if neutron_converter_flavor: | ||
| requested_module_name = f"neutron_converter_{neutron_converter_flavor}" | ||
| print( |
Collaborator
There was a problem hiding this comment.
Minor:
We usually use logging.warning() instead of print.
jirioc
force-pushed
the
nxf96559/feature/EIEX-657-implement-loader-for-eiq-neutron-sdk-converter-module
branch
from
a83974f to
d93861d
Compare
robert-kalmar
added
the
module: nxp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implemented the loader for eIQ Neutron SDK converter.
Test plan
Tested using the backends/nxp/tests/test_neutron_converter_manager.py which was also updated.
cc @robert-kalmar @JakeStevens @digantdesai