Skip to content

Conversation

@kirklandsign
Copy link
Contributor

Summary

Test plan

CI

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16303

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 913c77e with merge base 43a32eb (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 17, 2025
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@kirklandsign kirklandsign marked this pull request as ready for review December 18, 2025 09:35
Copilot AI review requested due to automatic review settings December 18, 2025 09:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the QNN (Qualcomm Neural Network) Android AAR build by correcting the library path and fixing the QNN Runner constructor call.

  • Updates QNN shared library path to match new CMake output directory structure
  • Fixes QNN Runner instantiation by adding missing constructor parameter and adjusting variable scope

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
scripts/build_android_library.sh Updates the QNN library copy path to reflect the new CMake output structure with executorch/backends/qualcomm/ subdirectory
extension/android/jni/jni_layer_llama.cpp Moves data_files_vector declaration to broader scope and adds missing performance_output_path parameter to QNN Runner constructor

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kirklandsign kirklandsign merged commit 793180f into main Dec 18, 2025
170 of 171 checks passed
@kirklandsign kirklandsign deleted the qnn-fix-build branch December 18, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants