-
Notifications
You must be signed in to change notification settings - Fork 775
Arm backend: Make upstream testing more target specific #15920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Arm backend: Make upstream testing more target specific #15920
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15920
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 7bb11ee with merge base d4ce813 ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
c65561b to
73d6d13
Compare
|
@metascroy has imported this pull request. If you are a Meta employee, you can view this in D88086613. |
|
These changes look fine to me, but we're currently having issues running any CI in PyTorch due to #16017 |
|
@metascroy CI seen to be fixed now and I rebased to retrigget job, now Meta internal and rebased version differ and we need help to re-import, hope that is OK |
Re-imported |
|
Oh no :( @Michiel-Olieslagers another bad named test case has sneeked passed this PR I do not know why the test-arm-ootb-linux tests fails :( |
|
I believe with our current test names we will encounter a lot of errors within the tosa & no_target jobs. I am currently working on a patch to implement a stricter naming convention to resolve this issue in the future. Regarding the ootb tests, I will need to investigate this a little bit more as this isn't linked to this issue. |
This patch splits up our upstream testing such that only relevant items are installed and only required things are tested upstream. It removes any duplicate testing and makes the upstream testing structure more transparent and readable. (Rebased & fixed certain syntactical issues in CI tests) Change-Id: I14cf329eed03d9859aef97204a9f12185b9533a2
Change-Id: I695c2563b3f1ebcbd6b6eb660dff36c305c0325a
a3054d9 to
7cd2995
Compare
Fixed call to wrong location for arm-scratch-dir and changed no_target function behaviour. Change-Id: Idf292ee747ffcf8ffed13d725849cc686d4c60af Signed-off-by: Michiel Olieslagers <michiel.olieslagers@arm.com>
7cd2995 to
17f97d2
Compare
This patch splits up our upstream testing such that only relevant items are installed and only required things are tested upstream. It removes any duplicate testing and makes the upstream testing structure more transparent and readable.
Change-Id: I14cf329eed03d9859aef97204a9f12185b9533a2
cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai