Skip to content

Conversation

@Michiel-Olieslagers
Copy link
Collaborator

@Michiel-Olieslagers Michiel-Olieslagers commented Nov 20, 2025

This patch splits up our upstream testing such that only relevant items are installed and only required things are tested upstream. It removes any duplicate testing and makes the upstream testing structure more transparent and readable.

Change-Id: I14cf329eed03d9859aef97204a9f12185b9533a2

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 20, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15920

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 7bb11ee with merge base d4ce813 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 20, 2025
@Michiel-Olieslagers Michiel-Olieslagers added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: none Do not include this in the release notes and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Nov 20, 2025
@zingo zingo changed the title Make upstream testing more target specific Arm backend: Make upstream testing more target specific Nov 20, 2025
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 20, 2025
@Michiel-Olieslagers Michiel-Olieslagers force-pushed the change-1126014 branch 4 times, most recently from c65561b to 73d6d13 Compare November 25, 2025 09:49
@zingo zingo requested a review from metascroy November 27, 2025 10:20
@meta-codesync
Copy link

meta-codesync bot commented Dec 1, 2025

@metascroy has imported this pull request. If you are a Meta employee, you can view this in D88086613.

@metascroy
Copy link
Contributor

These changes look fine to me, but we're currently having issues running any CI in PyTorch due to #16017

@zingo
Copy link
Collaborator

zingo commented Dec 1, 2025

@metascroy CI seen to be fixed now and I rebased to retrigget job, now Meta internal and rebased version differ and we need help to re-import, hope that is OK

@metascroy
Copy link
Contributor

@metascroy CI seen to be fixed now and I rebased to retrigget job, now Meta internal and rebased version differ and we need help to re-import, hope that is OK

Re-imported

@zingo
Copy link
Collaborator

zingo commented Dec 4, 2025

Oh no :( @Michiel-Olieslagers another bad named test case has sneeked passed this PR

def test_fail_dump_tosa_ops(capsys, test_data: input_t1):
   ...
    pipeline = EthosU55PipelineINT[input_t1](...

I do not know why the test-arm-ootb-linux tests fails :(

@Michiel-Olieslagers
Copy link
Collaborator Author

I believe with our current test names we will encounter a lot of errors within the tosa & no_target jobs. I am currently working on a patch to implement a stricter naming convention to resolve this issue in the future. Regarding the ootb tests, I will need to investigate this a little bit more as this isn't linked to this issue.

@zingo zingo marked this pull request as draft December 17, 2025 16:58
@zingo zingo marked this pull request as ready for review December 19, 2025 06:17
This patch splits up our upstream testing such that only relevant items are installed and only
required things are tested upstream. It removes any duplicate testing and makes the upstream
testing structure more transparent and readable.

(Rebased & fixed certain syntactical issues in CI tests)

Change-Id: I14cf329eed03d9859aef97204a9f12185b9533a2
Change-Id: I695c2563b3f1ebcbd6b6eb660dff36c305c0325a
@Michiel-Olieslagers Michiel-Olieslagers force-pushed the change-1126014 branch 2 times, most recently from a3054d9 to 7cd2995 Compare December 22, 2025 18:04
Fixed call to wrong location for arm-scratch-dir and changed
no_target function behaviour.

Change-Id: Idf292ee747ffcf8ffed13d725849cc686d4c60af
Signed-off-by: Michiel Olieslagers <michiel.olieslagers@arm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

Status: To triage

Development

Successfully merging this pull request may close these issues.

3 participants