Fix blackwell CUTLASS attention meta registration + actually test compile #5259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pile Summary: X-link: facebookresearch/FBGEMM#2248 The meta registration(s) were not correct and compile testing was incorrectly not testing compile. * Pass `compile=True` to tests (D89333698) * Fix meta registrations * Use `torch.no_grad()` to avoid "missing backwards" errors for some compile tests * Call a separate test func for the decode path (D89346059) Reviewed By: henrylhtsang Differential Revision: D89398632
Contributor
|
@jbschlosser has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89398632. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/2248
The meta registration(s) were not correct and compile testing was incorrectly not testing compile.
compile=Trueto tests (D89333698)torch.no_grad()to avoid "missing backwards" errors for some compile testsReviewed By: henrylhtsang
Differential Revision: D89398632