Optimize benchmark index generation with std::sample() #5254
+42
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 17, 2025 14:42
…rch#5253) Summary: X-link: facebookresearch/FBGEMM#2244 The dedup_map variable was declared but never used in the EmbeddingSpMDM benchmark files. This cleanup removes the dead code and the now-unused <map> and <set> includes that were only needed for that variable. Reviewed By: amitaga Differential Revision: D89335855
Summary: X-link: facebookresearch/FBGEMM#2245 The benchmarks were calling iota() and shuffle() on a 4M element vector for each batch iteration, resulting in ~80M operations per setup. Using std::sample() reduces this to O(k) per batch where k is the number of indices needed (~100-200), significantly reducing benchmark setup overhead. Differential Revision: D89337685
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/2245
The benchmarks were calling iota() and shuffle() on a 4M element vector for each batch iteration, resulting in ~80M operations per setup. Using std::sample() reduces this to O(k) per batch where k is the number of indices needed (~100-200), significantly reducing benchmark setup overhead.
Differential Revision: D89337685