Remove unused dedup_map and associated includes from benchmarks #5253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The dedup_map variable was declared but never used in the EmbeddingSpMDM benchmark files. This cleanup removes the dead code and the now-unused <map> and <set> includes that were only needed for that variable. Reviewed By: amitaga Differential Revision: D89335855
Contributor
terdogan
pushed a commit
to terdogan/FBGEMM
that referenced
this pull request
Dec 17, 2025
…rch#5253) Summary: X-link: facebookresearch/FBGEMM#2244 The dedup_map variable was declared but never used in the EmbeddingSpMDM benchmark files. This cleanup removes the dead code and the now-unused <map> and <set> includes that were only needed for that variable. Reviewed By: amitaga Differential Revision: D89335855
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The dedup_map variable was declared but never used in the EmbeddingSpMDM benchmark files. This cleanup removes the dead code and the now-unused and includes that were only needed for that variable.
Reviewed By: amitaga
Differential Revision: D89335855