Optimize group_index_select_or_add_2d_kernel on ROCm by adding a separate codepath for small embedding dimensions #5233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
…p_index_select_or_add_2d_kernel
…zed small embedding dims path
…isable optimized smallEmbD path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimizes the performance on ROCm of the
group_index_select_or_add_2d_kernelkernel on tables with small embedding dimensions (i.e.,num_cols).For tables with small embedding dimensions, the code is refactored to process multiple rows within the same warp. Two files are changed:
fbgemm_gpu/src/sparse_ops/sparse_ops_gpu.cpp- The calculation of thewarp_offsetsis changed in the host-side code.fbgemm_gpu/src/sparse_ops/sparse_group_index.cu- Thegroup_index_select_or_add_2d_kernelkernel is modified to process multiple rows within a warp for small embedding dimensions.