Skip to content

Adding returnKVTensorMetaData flag to Staging Read Strategy #5200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Raahul46 wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −0
Open

Adding returnKVTensorMetaData flag to Staging Read Strategy #5200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions fbgemm_gpu/src/ssd_split_embeddings_cache/kv_tensor_wrapper_cpu.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,4 +108,10 @@ std::string KVTensorWrapper::layout_str() {
oss << options_.layout();
return oss.str();
}

std::vector<std::string> KVTensorWrapper::get_kvtensor_serializable_metadata()
const {
FBEXCEPTION("Not implemented");
return std::vector<std::string>{};
}
} // namespace ssd
4 changes: 4 additions & 0 deletions fbgemm_gpu/src/ssd_split_embeddings_cache/ssd_split_table_batched_embeddings.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,6 +415,10 @@ std::string KVTensorWrapper::serialize() const {
std::vector<std::string> KVTensorWrapper::get_kvtensor_serializable_metadata()
const {
std::vector<std::string> metadata;
// Return empty metadata if checkpoint_handle_ is not initialized yet
if (checkpoint_handle_ == nullptr) {
return metadata;
}
auto* db = dynamic_cast<EmbeddingRocksDB*>(db_.get());
auto checkpoint_paths = db->get_checkpoints(checkpoint_handle_->uuid);
metadata.push_back(std::to_string(checkpoint_paths.size()));
Expand Down
Loading