GH-75949: Fix argparse dropping '|' in mutually exclusive groups on line wrap #142312
+49
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savannahostrowski
added
needs backport to 3.13
ayushHardeniya
approved these changes
Dec 5, 2025
serhiy-storchaka
approved these changes
Dec 6, 2025
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM. 👍
There is a larger issue when mutually exclusive groups are mixed with other arguments, but that case does not work even without wrapping.
serhiy-storchaka
approved these changes
Dec 6, 2025
|
Thanks @savannahostrowski for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 6, 2025
…s on line wrap (pythonGH-142312) (cherry picked from commit 5be3405) Co-authored-by: Savannah Ostrowski <savannah@python.org>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 6, 2025
…s on line wrap (pythonGH-142312) (cherry picked from commit 5be3405) Co-authored-by: Savannah Ostrowski <savannah@python.org>
|
GH-142347 is a backport of this pull request to the 3.14 branch. |
|
GH-142348 is a backport of this pull request to the 3.13 branch. |
savannahostrowski
pushed a commit
that referenced
this pull request
Dec 6, 2025
savannahostrowski
pushed a commit
that referenced
this pull request
Dec 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.