Don't require anthropic dependency when using Anthropic model with other provider
#3652
Conversation
| ), | ||
| # Bedrock does not support native structured output | ||
| supports_json_schema_output=False, | ||
| json_schema_transformer=None, |
There was a problem hiding this comment.
BedrockProvider is not the only one that uses anthropic_model_profile, so with this changes the other providers still have the same issue.
I think we should implement this as I suggested in #3625 (comment):
That means moving the
AnthropicJsonSchemaTransformerbit out ofpydantic_ai.profiles.anthropic.anthropic_model_profile, and intoAnthropicProvider.model_profile.
So anthropic_model_profile should not have any json_schema_transformer, and we should add it in AnthropicProvider.model_profile That way, AnthropicJsonSchemaTransformer will only be used with AnthropicProvider, not any other provider.
| def model_profile(self, model_name: str) -> ModelProfile | None: | ||
| return anthropic_model_profile(model_name) | ||
| profile = anthropic_model_profile(model_name) | ||
| if profile: |
There was a problem hiding this comment.
I liked the ModelProfile.from_profile(profile).update(...) (or ModelProfile(...).update(profile)) approach you had before better exactly because it also does the right thing when anthropic_model_profile returns None
There was a problem hiding this comment.
fixed it now, sorry about that
DouweM
changed the title
anthropic dependency when using Anthropic model with other provider
2 participants
Fixes #3625
many thanks to @nataziel for the reporting and suggesting a fix