include all fields by default #82
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
@proofkit/better-auth
@proofkit/cli
create-proofkit
@proofkit/fmdapi
@proofkit/fmodata
@proofkit/typegen
@proofkit/webviewer
commit: |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
eluce2
force-pushed
the
12-19-include_all_fields_by_default
branch
from
6a2c2bf to
edecb0a
Compare
eluce2
changed the base branch from
fix_username/password_auth
to
graphite-base/82
…lFieldsByDefault logic
eluce2
changed the base branch from
graphite-base/82
to
fix_username/password_auth
| allTablesConfig, | ||
| setValue, | ||
| fieldsData, | ||
| topLevelIncludeAllFieldsByDefault, |
There was a problem hiding this comment.
excludeAllFields not updated for new include-by-default setting
The includeAllFields function was updated to conditionally handle the effectiveIncludeAllFieldsByDefault setting with two branches of logic (one for true, one for false), but the excludeAllFields function was not similarly updated. When includeAllFieldsByDefault is false, fields not in the config array are already excluded by default, so the correct "exclude all" behavior would be to clear the fields array. Instead, excludeAllFields always adds every field with exclude: true, creating redundant config entries. Additionally, the dependency array is missing topLevelIncludeAllFieldsByDefault.
| const fieldConfig = Array.isArray(fieldsConfig) | ||
| ? fieldsConfig.find((f) => f?.fieldName === fieldName) | ||
| : undefined; | ||
| const isExcluded = fieldConfig?.exclude === true; |
There was a problem hiding this comment.
setFieldTypeOverride doesn't preserve field when clearing override
The setFieldTypeOverride function wasn't updated to account for includeAllFieldsByDefault. When removing a typeOverride and only fieldName remains, the code removes the entire field entry (lines 466-496). However, when includeAllFieldsByDefault is false, removing the field entry causes the field to become excluded, since fields not in the config array are excluded by default. This means clearing a type override unintentionally excludes the field. The function needs to preserve the field entry when includeAllFieldsByDefault is false, and its dependency array is also missing topLevelIncludeAllFieldsByDefault.
Note
Introduce
includeAllFieldsByDefault(top-level and per-table) to control field inclusion for OData generation and expose it across the UI and generator.includeAllFieldsByDefaulttofmodatatop-level and per-table schemas inpackages/typegen/src/types.ts.generateODataTypesandgenerateTableOccurrencehonorincludeAllFieldsByDefault(table override > top-level; defaulttrue) to filter generated fields based on explicitfieldswhen false.App.tsxfor new OData configs.ConfigEditor, add switch for top-levelincludeAllFieldsByDefault.MetadataFieldsDialog:includeAllFieldsByDefaultfor per-field include/exclude logic, counts, and bulk actions; add per-table override select.fields/table entries safely.MetadataTablesEditor, compute included field counts based on effective setting and displayincluded/totalwhen applicable.Written by Cursor Bugbot for commit c8be2f8. This will update automatically on new commits. Configure here.