-
Notifications
You must be signed in to change notification settings - Fork 135
Show Profvis output in an editor tab #11067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
E2E Tests 🚀 |
|
The Python tests are failing because ... the disk is full? |
|
Created an issue for that test: #11092 |
| // in the Viewer tab. If so, clear the `is_plot` flag so that | ||
| // in the Viewer tab. If so, update the destination so that | ||
| // we open the file in the Viewer. | ||
| const openInViewer = this._configurationService.getValue<boolean>(POSITRON_PREVIEW_PLOTS_IN_VIEWER); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drive by thought, should POSITRON_PREVIEW_PLOTS_IN_VIEWER allow opening in an editor as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe? It seems a little severe to open up an editor for every new plot, but we could allow folks to do that if they want to.
This change adds a small feature that opens Profvis output in an editor tab in Positron, similar to how Profvis output is treated in RStudio.
Requires posit-dev/ark#988. This is a breaking change in the UI comm protocol, so the merges must be coordinated.
Addresses #3269.
Release Notes
New Features
Bug Fixes
QA Notes