Skip to content

Conversation

@jmcphers
Copy link
Collaborator

This change adds a small feature that opens Profvis output in an editor tab in Positron, similar to how Profvis output is treated in RStudio.

image

Requires posit-dev/ark#988. This is a breaking change in the UI comm protocol, so the merges must be coordinated.

Addresses #3269.

Release Notes

New Features

Bug Fixes

  • N/A

QA Notes

  • The Profvis website has many examples you can try
  • Profvis isn't very good about responding to resizes and renders at a fairly fixed size regardless of the editor tab dimensions
  • Compare behavior to RStudio

@github-actions
Copy link

github-actions bot commented Dec 11, 2025

E2E Tests 🚀
This PR will run tests tagged with: @:critical

readme  valid tags

@jmcphers
Copy link
Collaborator Author

The Python tests are failing because ... the disk is full?

  Moving to /home/runner/work/positron/positron/extensions/positron-python/.nox/test_minimum_reqs-lightning-2-1-4-torch-1-12-1-numpy-1-24-4-pandas-1-5-3/lib/python3.9/site-packages/torchgen/
   from /home/runner/work/positron/positron/extensions/positron-python/.nox/test_minimum_reqs-lightning-2-1-4-torch-1-12-1-numpy-1-24-4-pandas-1-5-3/lib/python3.9/site-packages/~orchgen
ERROR: Could not install packages due to an OSError: [Errno 28] No space left on device

@austin3dickey
Copy link
Contributor

Created an issue for that test: #11092

// in the Viewer tab. If so, clear the `is_plot` flag so that
// in the Viewer tab. If so, update the destination so that
// we open the file in the Viewer.
const openInViewer = this._configurationService.getValue<boolean>(POSITRON_PREVIEW_PLOTS_IN_VIEWER);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive by thought, should POSITRON_PREVIEW_PLOTS_IN_VIEWER allow opening in an editor as well?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe? It seems a little severe to open up an editor for every new plot, but we could allow folks to do that if they want to.

DavisVaughan
DavisVaughan previously approved these changes Dec 15, 2025
@jmcphers jmcphers merged commit 7794316 into main Dec 16, 2025
32 checks passed
@jmcphers jmcphers deleted the feature/profvis-output branch December 16, 2025 04:39
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants