Skip to content

Conversation

@karlhorky
Copy link

@karlhorky karlhorky commented Jun 10, 2025

Thanks for this project, useful to check out how configuration of circular-dependency-plugin is being used in Next.js projects!

Currently, circular dependencies are logged by the config in next-circular-dependency, but the final onEnd callback will show No circular dependencies found:

♻️ Circular dependency detected: server/a.ts -> server.b.ts -> server/c.ts -> server/a.ts
♻️ Circular dependency detected: server.b.ts -> server/c.ts -> server/a.ts -> server.b.ts
✅ No circular dependencies found in server

Switching to the external tracking of compilation.name -> arrays of the detected dependency messages resolves the issue:

♻️ Circular dependency detected: server/a.ts -> server.b.ts -> server/c.ts -> server/a.ts
♻️ Circular dependency detected: server.b.ts -> server/c.ts -> server/a.ts -> server.b.ts
❌ 2 circular dependencies found in server

@karlhorky karlhorky marked this pull request as draft June 10, 2025 13:07
@karlhorky karlhorky changed the title Change to failOnError: true to show errors Switch to external mapping of detected circular dependencies Jun 10, 2025
@karlhorky karlhorky marked this pull request as ready for review June 10, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant