Skip to content

Conversation

@carl-adams-planet
Copy link
Collaborator

No description provided.

Copy link

@tbarsballe tbarsballe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual implementation here looks good to me.
The one thing I noticed is there's a bunch of commented out code floating around, which I find to be bad practice - if that's something that might get added/restored in the future, I'd rather see a standalone commit that just removes the unused functionality and can later be reverted over scattered blocks of commented code

@carl-adams-planet
Copy link
Collaborator Author

The actual implementation here looks good to me. The one thing I noticed is there's a bunch of commented out code floating around, which I find to be bad practice - if that's something that might get added/restored in the future, I'd rather see a standalone commit that just removes the unused functionality and can later be reverted over scattered blocks of commented code

Yeah. I have a tendency to lave these ideas around in comments, but you are right and 9 out of 10 times I never follow up on them.

I'll clean it up before merging.

@carl-adams-planet carl-adams-planet merged commit de921bc into main Dec 5, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants