Add multi-protocol support for rolling upgrades for v5.0.x -> v6.0.0 #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mason-sharp
reviewed
Dec 1, 2025
rasifr
force-pushed
the
task/SPOC-337/rolling-upgrades
branch
2 times, most recently
from
e2f3aac to
5fd51f0
Compare
….0.0 This change implements protocol version negotiation to enable rolling upgrades from Spock v5.0.0 through v6.0.0 without breaking replication. Protocol 4 (v5.0.0-5.0.4): remote_insert_lsn at end of COMMIT only Protocol 5 (v6.0.0+): remote_insert_lsn at beginning of all messages (v5.0.5+): Same as v6.0.0, once backported. Key changes: - Protocol negotiation: Min(server_max, client_max) - Conditional message format based on negotiated version - Backward compatible: defaults to protocol 4 for v5.0.4 and below publishers - Version guard: requires both nodes >= v5.0.0
Tests multi-protocol negotiation during rolling upgrades: - Builds v5_STABLE and v6 to separate temp directories - Verifies v5 <-> v5 bidirectional replication - Upgrades node 1 to v6, tests mixed-version (v5 <-> v6) - Upgrades node 2 to v6, tests v6 <-> v6 replication - Covers INSERT, UPDATE, DELETE, batch ops, DDL, and TRUNCATE
rasifr
force-pushed
the
task/SPOC-337/rolling-upgrades
branch
from
5fd51f0 to
540045b
Compare
mason-sharp
changed the title
mason-sharp
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements protocol version negotiation to enable rolling upgrades from Spock v5.0.0 through v6.0.0 without breaking replication.
Protocol 4 (v5.0.0-5.0.4): remote_insert_lsn at end of COMMIT only
Protocol 5 (v6.0.0+): remote_insert_lsn at beginning of all messages
(v5.0.5+): Same as v6.0.0, once backported.
Key changes: