zodan.sql - add subscription health check (Spoc 294). #266
+198
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibrarahmad
reviewed
Nov 14, 2025
| 4, | ||
| 0, | ||
| INT_MAX, | ||
| MAX_KILOBYTES / 1024, |
Contributor
There was a problem hiding this comment.
What is reason to change that?
Contributor
Author
There was a problem hiding this comment.
It is just because of boring complain in the log. We assign this GUC in terms of megabytes, so we need to declare units and proper limits too.
ibrarahmad
requested changes
Nov 14, 2025
| ok($result eq '1', "Check state of the test table on N3 after the attachment"); | ||
| print STDERR "Z0DAN should add N3 to the cluster\n"; | ||
|
|
||
| # ############################################################################## |
Contributor
There was a problem hiding this comment.
I don't understand the reason?
Contributor
Author
There was a problem hiding this comment.
Reason for what exactly?
Contributor
Author
There was a problem hiding this comment.
I don't understand the reason?
Do you mean, reason for a new test or some check inside?
Contributor
|
Please resove conflicts |
With this commit, we require that each node of the Spock cluster has only enabled subscriptions. There is no algorithmic reason to do that, because when adding the node, we are concerned only about the donor's state and the consistency of its progress table. However, such a strict procedure ensures that users can be sure they add a node to a healthy cluster, take action beforehand if it is not healthy, and that replication doesn't delay WAL cutting. Introduce a TAP test that could be used to check Z0DAN checks. XXX: add_node finishes its job with subscriptions in the 'initialising' state. Do we need to take any action here? Also, fix the annoying WARNING on the 'exception_replay_queue_size'.
Contributor
Author
Done. |
If no group's subscription is enabled, wait_for_sync_event may get stuck in an infinite loop. Add a check of the subscription state in the waiting loop to reflect the fact that an apply worker may quietly die, deactivating its subscription. Also, add the correct processing of this behaviour to the Z0DAN and include a TAP test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.