-
Notifications
You must be signed in to change notification settings - Fork 53
[WIP] Annotations #274
base: master
Are you sure you want to change the base?
[WIP] Annotations #274
Conversation
|
looks good 👍 |
|
Perhaps you can just reuse your existing server backend with the constraint of |
js/revieweditor.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the concept of a 'session' and the memberListView are tied together, there is no avoiding the member list construction for now. So I suggest adding another line editorOptions.collabEditingEnabled = true;, and then hiding the Member List through CSS.
|
@VicDeo any update here, is this ready for review? Can you rebase before? |
d8b54e6 to
228d92d
Compare
|
with the new version being merged, isn't this in already? ;-) |
|
@jospoortvliet not exactly. This is about |
|
ah, ok, that's a cool feature! |
No description provided.