Skip to content

fix Ref{Any}(p::TensorProto) #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clouds56 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix Ref{Any}(p::TensorProto) #6

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
635df69
fix `Ref{Any}(p::TensorProto)`
clouds56 Aug 18, 2021
ad3dc06
fix attribute would change content
clouds56 Aug 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/read.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@

# Convenience function to allow for things like Array(tp) or CuArray(tp)
# Not sure if this counts as type piracy...
(::Type{T})(p::TensorProto) where T = array(p) |> T
(::Type{Ref{T}})(p::TensorProto) where T = array(p) |> T |> Ref
(::Type{T})(p::TensorProto) where T <: AbstractArray = array(p) |> T
(::Type{Ref{T}})(p::TensorProto) where T <: AbstractArray = array(p) |> T |> Ref


"""
Expand Down Expand Up @@ -67,9 +67,9 @@ function attribute(p::AttributeProto)
if (p._type != 0)
field = [:f, :i, :s, :t, :g, :floats, :ints, :strings, :tensors, :graphs][p._type]
if field === :s
return Symbol(p.name) => String(getfield(p, field))
return Symbol(p.name) => String(copy(getfield(p, field)))
elseif field === :strings
return Symbol(p.name) => String.(getfield(p, field))
return Symbol(p.name) => String.(copy.(getfield(p, field)))
end
return Symbol(p.name) => getfield(p, field)
end
Expand Down