Skip to content

Conversation

@oliverguenther
Copy link
Member

Extended from #19011

Solves this:

Not sure if this line for handling legacy configs could use some change too.

What are you trying to accomplish?

  • Fix the broken OpenProject 16 Docker (All-in-One and docker compose) PostgreSQL Upgrade.
  • Fix the old OpenProject image version to 16.

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@oliverguenther oliverguenther force-pushed the update-postgres-references branch from fb0db32 to 43f91b0 Compare June 20, 2025 06:16
@github-actions
Copy link

Caution

The provided work package version does not match the core version

Details:

Please make sure that:

  • The work package version OR your pull request target branch is correct

echo "-----> Existing PostgreSQL cluster found in $PGDATA."

# Check for version mismatch: if Docker default is PG 17 but existing data is PG 13
if [ "$PGVERSION" = "17" ] && [ "$EXISTING_PGVERSION" = "13" ]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oliverguenther Should we perhaps not make this specific to 17 and 13 but show this warning in general if there is a mismatch between the set PGVERSION and the one found in the cluster?

I know coming from our own setups, this should be the only combination really, but it probably doesn't hurt to catch more potential issues here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

@machisuji
Copy link
Member

@oliverguenther Since we are now using Postgres 17 to generate the schema cache during the docker build, this failed due to missing permissions. I've pushed a commit that fixes that. With that this should look fine.

I was wondering if the used postgres version has any bearing on the generated schema cache. But it doesn't seem to be a problem for our containers with the pg13-generated schema cache using more recent versions, so I suppose not.

As soon as CI is green this can be merged as far as I'm concerned.

Copy link
Member

@machisuji machisuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oliverguenther oliverguenther merged commit 1fc574c into dev Jun 23, 2025
11 of 12 checks passed
@oliverguenther oliverguenther deleted the update-postgres-references branch June 23, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants