Skip to content

Conversation

@tmshort
Copy link
Contributor

@tmshort tmshort commented Dec 19, 2025

Requires goreleaser v2.12.7
Updating the darwin build as done downstream

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@tmshort tmshort added the override-go-verdiff Override go-verdiff test. label Dec 19, 2025
@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.49%. Comparing base (de37a21) to head (2fdb154).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1866      +/-   ##
==========================================
- Coverage   57.50%   57.49%   -0.01%     
==========================================
  Files         136      136              
  Lines       12934    12934              
==========================================
- Hits         7438     7437       -1     
- Misses       4341     4342       +1     
  Partials     1155     1155              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2025
@tmshort tmshort force-pushed the go1.25 branch 2 times, most recently from 0b08a64 to e1733de Compare December 19, 2025 20:56
Copy link
Contributor

@ankitathomas ankitathomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ankitathomas, rashmigottipati
Once this PR has been reviewed and has the lgtm label, please assign perdasilva for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Requires goreleaser v2.11.2
Updating the darwin build as done downstream

Signed-off-by: Todd Short <todd.short@me.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 19, 2025

New changes are detected. LGTM label has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

override-go-verdiff Override go-verdiff test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants