Skip to content

perf: custom xorin keccak #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
GunaDD wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

perf: custom xorin keccak #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7dbbbef
perf: make xorin and keccak call a function that matches the new kecc…
GunaDD Dec 5, 2025
c852320
feat: import openvm-keccak256-guest
GunaDD Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ categories = ["cryptography", "no-std"]

[dependencies]
crunchy = "0.2.2"
openvm-keccak256-guest = { git = "https://github.com/openvm-org/openvm", branch = "feat/new-keccak", package = "openvm-keccak256-guest" }

[profile.dev]
opt-level = 3 # Controls the --opt-level the compiler builds with
Expand Down
33 changes: 19 additions & 14 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,20 +333,19 @@ impl Buffer {
self.execute(offset, len, |buffer| dst[..len].copy_from_slice(buffer));
}

fn xorin_openvm_opcode(&mut self, mut buffer_ptr: *mut u8, input_ptr: *const u8, len: usize) {
let buf_u8: &mut [u8; 200] = unsafe { &mut *(buffer_ptr as *mut [u8; 200]) };
let input_u8: &[u8] = unsafe { core::slice::from_raw_parts(input_ptr as *const u8, len) };

for i in 0..len {
buf_u8[i] ^= input_u8[i];
}
}

fn xorin(&mut self, src: &[u8], offset: usize, len: usize) {
self.execute(offset, len, |dst| {
assert!(dst.len() <= src.len());
let len = dst.len();
let mut dst_ptr = dst.as_mut_ptr();
let mut src_ptr = src.as_ptr();
for _ in 0..len {
unsafe {
*dst_ptr ^= *src_ptr;
src_ptr = src_ptr.offset(1);
dst_ptr = dst_ptr.offset(1);
}
}
});
let buffer_ptr = unsafe { (self.0.as_mut_ptr() as *mut u8).add(offset) };
let input_ptr = src.as_ptr();
self.xorin_openvm_opcode(buffer_ptr, input_ptr, len);
}

fn pad(&mut self, offset: usize, delim: u8, rate: usize) {
Expand Down Expand Up @@ -400,8 +399,14 @@ impl<P: Permutation> KeccakState<P> {
}
}

fn keccak_openvm_opcode(&mut self, mut buffer_ptr: *mut u8) {
let buffer: &mut Buffer = unsafe { &mut *(buffer_ptr as *mut Buffer) };
keccakf(buffer.words());
}

fn keccak(&mut self) {
P::execute(&mut self.buffer);
let buffer_ptr = unsafe { self.buffer.0.as_mut_ptr() as *mut u8 };
self.keccak_openvm_opcode(buffer_ptr);
}

fn update(&mut self, input: &[u8]) {
Expand Down