-
Notifications
You must be signed in to change notification settings - Fork 81
feat: update to provable params #2301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
df6399c to
21f0185
Compare
This comment has been minimized.
This comment has been minimized.
73ba309 to
8888e88
Compare
21f0185 to
87481da
Compare
This comment has been minimized.
This comment has been minimized.
87481da to
134414e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
7cb0804 to
c376e72
Compare
CodSpeed Performance ReportMerging #2301 will not alter performanceComparing
|
99b26b6 to
d575f1c
Compare
This comment has been minimized.
This comment has been minimized.
d575f1c to
0ceb3ac
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
57e9e23 to
b8064c4
Compare
This comment has been minimized.
This comment has been minimized.
fffc4bc to
83a5ca7
Compare
b8064c4 to
066288d
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
8551eae to
d398027
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Commit: ee964ac |
jonathanpwang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I fixed Sdk constructor to never use testing constructor. I fixed the integration test: the reason is that if the leaf params has no queries but the internal params do, you can get a situation where no amount of recursion shrinks the proof enough.
Syncs with openvm-org/stark-backend#202
closes INT-5601