Skip to content

Conversation

@zlangley
Copy link
Contributor

@zlangley zlangley commented Dec 5, 2025

Syncs with openvm-org/stark-backend#202

closes INT-5601

@github-actions

This comment has been minimized.

@zlangley zlangley force-pushed the feat/provable-params branch from df6399c to 21f0185 Compare December 5, 2025 16:37
@github-actions

This comment has been minimized.

@jonathanpwang jonathanpwang changed the base branch from main to update-plonky3 December 17, 2025 07:44
@jonathanpwang jonathanpwang marked this pull request as ready for review December 17, 2025 07:44
@zlangley zlangley force-pushed the feat/provable-params branch from 21f0185 to 87481da Compare December 17, 2025 15:45
@github-actions

This comment has been minimized.

@zlangley zlangley force-pushed the feat/provable-params branch from 87481da to 134414e Compare December 17, 2025 16:20
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@jonathanpwang jonathanpwang added run-benchmark triggers benchmark workflows on the pr run-benchmark-e2e labels Dec 17, 2025
Base automatically changed from update-plonky3 to develop-v1.5.0 December 18, 2025 02:37
@zlangley zlangley force-pushed the feat/provable-params branch from 7cb0804 to c376e72 Compare December 18, 2025 17:58
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 18, 2025

CodSpeed Performance Report

Merging #2301 will not alter performance

Comparing feat/provable-params (ee964ac) with main (a1bce3e)1

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 24 untouched
⏩ 36 skipped2

Footnotes

  1. No successful run was found on develop-v1.5.0 (83a5ca7) during the generation of this report, so main (a1bce3e) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 36 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@zlangley zlangley force-pushed the feat/provable-params branch 7 times, most recently from 99b26b6 to d575f1c Compare December 19, 2025 16:41
@github-actions

This comment has been minimized.

@zlangley zlangley force-pushed the feat/provable-params branch from d575f1c to 0ceb3ac Compare December 19, 2025 18:17
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@zlangley zlangley force-pushed the feat/provable-params branch from 57e9e23 to b8064c4 Compare December 19, 2025 19:05
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair 728 621,589 3,608,490 - - -
fibonacci 1,616 1,500,209 2,100,402 3,883 3,999,477 19,821,452
regex 3,883 4,137,502 17,695,216 11,271 9,252,144 60,830,730
ecrecover 1,010 122,859 2,262,772 5,577 4,109,187 34,465,046
pairing 2,232 1,745,742 25,408,302 6,367 5,977,438 40,833,672
fib_e2e 5,816 12,000,209 14,203,554 26,963 24,071,196 124,637,876
kitchen_sink 3,733 154,763 18,338,948 10,494 12,577,391 125,247,500

Commit: ee964ac

Benchmark Workflow

Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I fixed Sdk constructor to never use testing constructor. I fixed the integration test: the reason is that if the leaf params has no queries but the internal params do, you can get a situation where no amount of recursion shrinks the proof enough.

@jonathanpwang jonathanpwang merged commit faf00ad into develop-v1.5.0 Dec 23, 2025
71 checks passed
@jonathanpwang jonathanpwang deleted the feat/provable-params branch December 23, 2025 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-benchmark triggers benchmark workflows on the pr run-benchmark-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants