Skip to content

feat(tree-menu): [tree-menu] Can adding nodes be clicked on the document #3878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zzcr merged 1 commit into from
Dec 9, 2025
+7 −4
Merged

feat(tree-menu): [tree-menu] Can adding nodes be clicked on the document #3878

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions examples/sites/demos/apis/tree-menu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,6 +660,9 @@ interface ITreeNodeData {
"number"?: number | string
// 自定义每个节点的图标
"customIcon": Component
// 节点是否可以点击
"disabled"?: string
Comment on lines +663 to +664
Copy link

@coderabbitai coderabbitai bot Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# First, let's locate the tree-menu.js file
find . -name "tree-menu.js" -type f

Repository: opentiny/tiny-vue

Length of output: 161

🏁 Script executed:

#!/bin/bash
# Read the specific file to see the context around lines 663-664 and 640
wc -l examples/sites/demos/apis/tree-menu.js

Repository: opentiny/tiny-vue

Length of output: 103

🏁 Script executed:

#!/bin/bash
# Read lines around 640 to see ITreeNodeVm definition
sed -n '630,680p' examples/sites/demos/apis/tree-menu.js

Repository: opentiny/tiny-vue

Length of output: 869

🏁 Script executed:

#!/bin/bash
# Search for ITreeNodeData and ITreeNodeVm definitions in the file
rg -n "interface ITreeNode|disabled" examples/sites/demos/apis/tree-menu.js | head -20

Repository: opentiny/tiny-vue

Length of output: 322

🏁 Script executed:

#!/bin/bash
# Search for the tree-menu component implementation (not the demo API docs)
find . -path "*/demos/apis" -prune -o -name "tree-menu.js" -o -name "tree-menu.ts" -o -name "tree-menu.vue" | grep -v demos/apis

Repository: opentiny/tiny-vue

Length of output: 120

🏁 Script executed:

#!/bin/bash
# Look for the actual tree-menu component source
find . -path "*/node_modules" -prune -o -path "*/demos" -prune -o -type f \( -name "tree-menu*" \) -print

Repository: opentiny/tiny-vue

Length of output: 106

🏁 Script executed:

#!/bin/bash
# Search in packages directory for tree-menu component
fd "tree-menu" --type f packages/ | head -20

Repository: opentiny/tiny-vue

Length of output: 104

🏁 Script executed:

#!/bin/bash
# Let's check how the disabled property flows through the component
# Search for how ITreeNodeData properties are mapped to ITreeNodeVm
rg -n "disabled" examples/sites/demos/apis/tree-menu.js -B2 -A2 | head -40

Repository: opentiny/tiny-vue

Length of output: 617

🏁 Script executed:

#!/bin/bash
# Read the renderless tree-menu types
cat -n packages/renderless/types/tree-menu.type.ts | head -100

Repository: opentiny/tiny-vue

Length of output: 3025

🏁 Script executed:

#!/bin/bash
# Search for disabled property handling in tree-menu types
rg -n "disabled" packages/renderless/types/tree-menu.type.ts -B2 -A2

Repository: opentiny/tiny-vue

Length of output: 43

🏁 Script executed:

#!/bin/bash
# Look for the tree-menu component implementation to see how data flows
find packages -name "*.ts" -o -name "*.js" | xargs rg -l "tree-menu" | grep -v ".d.ts" | head -5

Repository: opentiny/tiny-vue

Length of output: 220

🏁 Script executed:

#!/bin/bash
# Search for how the disabled property is actually used in tree-menu implementation
find packages -type f \( -name "*.ts" -o -name "*.js" \) -path "*/tree-menu/src/*" | head -10

Repository: opentiny/tiny-vue

Length of output: 100

🏁 Script executed:

#!/bin/bash
# Check tree-menu props to understand the structure
find packages -type f -name "props.ts" | xargs grep -l "tree-menu"

Repository: opentiny/tiny-vue

Length of output: 45

🏁 Script executed:

#!/bin/bash
# Read the tree-menu props file
fd "tree-menu" packages --type d | head -1 | xargs -I {} find {} -name "props.ts" -exec cat {} \;

Repository: opentiny/tiny-vue

Length of output: 43

🏁 Script executed:

#!/bin/bash
# Read the props file directly
cat -n packages/vue/src/tree-menu/src/props.ts | head -50

Repository: opentiny/tiny-vue

Length of output: 1365

🏁 Script executed:

#!/bin/bash
# Search for any documentation or comments about how disabled property flows
rg -n "disabled" packages/vue/src/tree-menu/ -B1 -A1 | head -30

Repository: opentiny/tiny-vue

Length of output: 43

Fix the documentation comment for semantic accuracy.

The comment on line 663 contradicts the property semantics. The comment "节点是否可以点击" (whether the node can be clicked) should be "是否禁用" (whether disabled) to match the disabled property name and align with the comment on line 639 in the ITreeNodeVm interface.

Note: The disabled property being typed as string in ITreeNodeData is intentional—it represents the field name used for mapping, not a data value. The actual boolean state is correctly defined in ITreeNodeVm.disabled.

-  // 节点是否可以点击
+  // 是否禁用
   "disabled"?: string
🤖 Prompt for AI Agents 
In examples/sites/demos/apis/tree-menu.js around lines 663 to 664, the
documentation comment for the "disabled" property is semantically incorrect
("节点是否可以点击"); change it to "是否禁用" to match the property name and align with the
ITreeNodeVm comment on line 639; keep the type as string since it represents a
field name mapping, not a boolean value.


}
`
},
Expand All @@ -668,10 +671,10 @@ interface ITreeNodeData {
type: 'interface',
code: `
interface IProps {
"label"?: string
"children"?: string
"disabled": string
"isLeaf": string
"label": string
"children": string
"disabled"?: string
"isLeaf"?: string
}
`
},
Expand Down
Loading