-
Notifications
You must be signed in to change notification settings - Fork 1
feat(docs): improve compose file in Getting Started #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @b-long, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the "Getting Started" documentation by externalizing the Docker Compose configuration into its own file and dynamically embedding it into the Docusaurus page. This change improves the maintainability of the documentation and ensures that the example Docker Compose setup is consistently presented and easily updated. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the Getting Started documentation by moving the Docker Compose configuration into a separate file, which is a great improvement for maintainability. I've reviewed the new docker-compose.yaml file and found several areas for improvement, primarily concerning security and best practices. My main concerns are the use of world-writable permissions (777), hardcoded default passwords, and unpinned Docker image versions. I've provided specific suggestions to address these issues.
f2b46d9 to
28be933
Compare
28be933 to
4ee684c
Compare
|
I've just gone through this process and tested it on my local machine and it worked for me. |
Current state
raw-loaderto pull in the docker-compose content from a fixed filedocker-compose.yamlFuture state
opentdf/platformrepositoryopentdf/docsgetting started pageTesting
npm install && npm run build && npm run serve. Open your web browser to http://localhost:3000/ , and click "Get Started" to view the updated page (or navigate directly to http://localhost:3000/getting-started ).Access the services: