Skip to content

Conversation

@Nbelles
Copy link

@Nbelles Nbelles commented Sep 20, 2024

This is in response to the issue: #22

Using the EXPOSE keyword in the Dockerfile forces people to expose both an HTTP port and an HTTPS port even if they don't want both ports. By removing this, it does not break any support for the normal expected use as described in this projects documentation of supplying the port using the command docker run -p 3000:8080 ... or using a docker compose file.

This fixes the problem when people want to remap some of the ports and not expose all of the ports (for instance only exposing an https port).

Please consider merging this into main or follow up with any concerns. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant