Removing unnecessary use of EXPOSE #32
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in response to the issue: #22
Using the EXPOSE keyword in the
Dockerfileforces people to expose both an HTTP port and an HTTPS port even if they don't want both ports. By removing this, it does not break any support for the normal expected use as described in this projects documentation of supplying the port using the commanddocker run -p 3000:8080 ...or using a docker compose file.This fixes the problem when people want to remap some of the ports and not expose all of the ports (for instance only exposing an https port).
Please consider merging this into main or follow up with any concerns. Thanks!