-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OCPBUG26050: Added a section for day2 operator for azure disk encryption sets. #72130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🤖 Fri Apr 11 14:56:37 - Prow CI generated the docs preview: |
|
This LGTM, but should have QE or the engineer responsible for this ack as well |
modules/installation-azure-day2-operations-diskencryptionsets.adoc
Outdated
Show resolved
Hide resolved
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/reopen |
|
/remove-lifecycle rotten |
|
@subhtk: Reopened this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
|
/remove-lifecycle rotten |
a2d8edb to
8bce5c5
Compare
modules/installation-azure-day2-operations-diskencryptionsets.adoc
Outdated
Show resolved
Hide resolved
installing/installing_azure/enabling-user-managed-encryption-azure.adoc
Outdated
Show resolved
Hide resolved
|
|
||
| include::modules/installation-azure-preparing-diskencryptionsets.adoc[leveloffset=+1] | ||
|
|
||
| include::modules/installation-azure-day2-operations-diskencryptionsets.adoc[leveloffset=+1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| include::modules/installation-azure-day2-operations-diskencryptionsets.adoc[leveloffset=+1] | |
| // Preparing an Azure Disk Encryption Set for Day2 Operator | |
| include::modules/installation-azure-day2-operations-diskencryptionsets.adoc[leveloffset=+1] |
Day 2 or post-installation? From my time on the installation team, they preferred post-isntallation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jinyunma can you take a look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section is applied optionally on running cluster, I thinks day2 should be okay.
But the section title looks confused.
During installation (day1), installer supports to enable disk encryption with both platform-managed keys and with customer-managed keys. If enabling with customer-managed keys, user needs to create resource disk encryption set to provide those keys, that's what describes in section Preparing an Azure Disk Encryption Set
For day2 operation, only encryption at host with platform-managed keys is verified with steps described in this PR. How about to update as "Enable disk encryption with platform-managed keys on day2"?
installing/installing_azure/enabling-user-managed-encryption-azure.adoc
Outdated
Show resolved
Hide resolved
installing/installing_azure/enabling-user-managed-encryption-azure.adoc
Outdated
Show resolved
Hide resolved
modules/installation-azure-day2-operations-diskencryptionsets.adoc
Outdated
Show resolved
Hide resolved
modules/installation-azure-day2-operations-diskencryptionsets.adoc
Outdated
Show resolved
Hide resolved
| $ oc adm uncordon <node_name> | ||
| ---- | ||
|
|
||
| . Make sure that all the operators are available. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| . Make sure that all the operators are available. | |
| . Make sure that all the operators are available. |
How?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jinyunma can you verify if this is the correct step:
. Verify that all cluster Operators are available:
+
[source,terminal]
----
$ oc get clusteroperators
----
+
All Operators should show `AVAILABLE=True`, `PROGRESSING=False`, and `DEGRADED=False`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about to check node status instead of operators status here? Similar as hardware update for VM on vSphere.
Power on VM -> Wait for the node to report as "Ready" ($ oc wait --for=condition=Ready node/<node_name>) -> Make the node as schedulable again ($ oc adm uncordon <node_name>)
Same procedures are also verified in our automation script.
modules/installation-azure-day2-operations-diskencryptionsets.adoc
Outdated
Show resolved
Hide resolved
modules/installation-azure-day2-operations-diskencryptionsets.adoc
Outdated
Show resolved
Hide resolved
|
@subhtk: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| [id="preparing-disk-encryption-sets-day2-operator_{context}"] | ||
| = Preparing an Azure Disk Encryption Set for Day2 Operator | ||
|
|
||
| The {product-title} installation program can use an existing Disk Encryption Set with a user-managed key. To enable this feature, create a `DiskEncryptionSet` in Azure and provide the key to the installation program. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on #72130 (comment), suggest to update here too, something like:
If disk encryption is not configured during installation, you can enable disk encryption with platform-managed keys on each node when cluster is up and running.
|
The This is because your PR targets the If the update in your PR does NOT apply to version 4.20 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
|
The This is because your PR targets the If the update in your PR does NOT apply to version 4.21 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main. |
|
Closed in favor of #101966 |
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s): 4.12+
Issue: OCPBUG-26050
Link to docs preview: Preview
QE review:
Additional information: