8374093: [lworld] Cleanup and polish around vgetfield/vputfield

[jsikstro]

Hello,

I've been looking at the new internal bytecodes vgetfield and vputfield and their callchains from the interpreter down to InlineKlass and have some cleanups. I've not looked at templateTable_x86 so far, only templateTable_aarch64.

Some notes:

• The dest_is_initialized parameter in InlineKlass::write_value_to_addr is true for all callers, so I've removed it and inlined true to the call to copy_payload_to_addr.
• There seems to be an unnecessary mark_payload_as_non_null((address)src); in InlineKlass::copy_payload_to_addr, as the payload should already be non_null if it doesn't match is_payload_marked_as_null in the if-statement just above.

Testing:

• hotspot_valhalla, jdk_valhalla and tier1

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JDK-8374093: [lworld] Cleanup and polish around vgetfield/vputfield (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1840/head:pull/1840
$ git checkout pull/1840

Update a local copy of the PR:
$ git checkout pull/1840
$ git pull https://git.openjdk.org/valhalla.git pull/1840/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1840

View PR using the GUI difftool:
$ git pr show -t 1840

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1840.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jsikstro! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[mlbridge]

Webrevs

• 01: Full - Incremental (e1f1ffa6)
• 00: Full (8944d003)