Skip to content

Conversation

@RogerRiggs
Copy link
Collaborator

@RogerRiggs RogerRiggs commented Dec 18, 2025

Revert "8366841: [lworld] Objects.equals without identity comparison". (Almost all)
Removing the condition on --enable-preview.
Correct the .equals method in test SimplValueGraphs.SimpleValue.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JDK-8373930: [lworld] Restore Objects.equals use of identity check (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1836/head:pull/1836
$ git checkout pull/1836

Update a local copy of the PR:
$ git checkout pull/1836
$ git pull https://git.openjdk.org/valhalla.git pull/1836/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1836

View PR using the GUI difftool:
$ git pr show -t 1836

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1836.diff

Using Webrev

Link to Webrev Comment

removing the condition on --enable-preview.
Correct the .equals method of SimplValueGraphs.SimpleValue.
Revert "8366841: [lworld] Objects.equals without identity comparison"
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 18, 2025

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 18, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 18, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 18, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant