Skip to content

Conversation

@YaSuenag
Copy link
Member

@YaSuenag YaSuenag commented Dec 6, 2025

JDK-8371194 (PR #28284) has broken PStack (jstack --mixed) behavior on macOS. It affects both AMD64 and AArch64. See JBS for details.

This PR fixes it to implement CFrame::toFrame.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8373110: jstack --mixed frames are broken on macOS after JDK-8371194

Issue

  • JDK-8373110: jstack --mixed frames are broken on macOS after JDK-8371194 (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28686/head:pull/28686
$ git checkout pull/28686

Update a local copy of the PR:
$ git checkout pull/28686
$ git pull https://git.openjdk.org/jdk.git pull/28686/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28686

View PR using the GUI difftool:
$ git pr show -t 28686

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28686.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 6, 2025

👋 Welcome back ysuenaga! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 6, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Dec 6, 2025
@openjdk
Copy link

openjdk bot commented Dec 6, 2025

@YaSuenag The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@YaSuenag YaSuenag marked this pull request as ready for review December 7, 2025 01:38
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 7, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 7, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfr Pull request is ready for review serviceability serviceability-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

1 participant