Skip to content

Conversation

Copy link

Copilot AI commented Dec 5, 2025

The release workflow could leave the repository in an inconsistent state if Maven Central deployment failed—tags and commits would still be created without an actual release.

Changes

  • Added if: success() conditions to all git operations post-deployment (commits, tags, pushes)
  • Added id: maven-deploy to deployment step for traceability
  • Added comments documenting the fail-fast dependency chain

Result

If deployment fails at any point:

  • No release commit is pushed
  • No release tag is created
  • No GitHub Release is published
  • No snapshot version bump occurs

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 2 commits December 5, 2025 21:25
Co-authored-by: kaikreuzer <3244965+kaikreuzer@users.noreply.github.com>
Co-authored-by: kaikreuzer <3244965+kaikreuzer@users.noreply.github.com>
@kaikreuzer
Copy link
Member

@copilot Please resolve conflicts

Copilot AI changed the title [WIP] Update release process implementation in GHA based on feedback Add explicit fail-fast behavior for Maven Central deployment in release workflow Dec 5, 2025
Copilot AI requested a review from kaikreuzer December 5, 2025 21:28
Copy link
Author

Copilot AI commented Dec 5, 2025

@copilot Please resolve conflicts

I'm unable to resolve merge conflicts directly. This is a limitation of my environment - I cannot pull branches from GitHub or perform rebases with force push.

Could you please either:

  1. Merge the release branch into this PR branch locally and push, or
  2. Resolve the conflicts through the GitHub UI if it allows that

Once the conflicts are resolved, I can continue addressing any remaining feedback.

Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer kaikreuzer marked this pull request as ready for review December 5, 2025 21:37
@kaikreuzer kaikreuzer requested a review from a team as a code owner December 5, 2025 21:37
@kaikreuzer kaikreuzer merged commit 841625c into release Dec 5, 2025
1 check passed
@kaikreuzer kaikreuzer deleted the copilot/sub-pr-497 branch December 5, 2025 21:37
holgerfriedrich pushed a commit to holgerfriedrich/static-code-analysis that referenced this pull request Dec 6, 2025
…se workflow (openhab#528)

* Initial plan

* Add explicit fail-fast behavior for Maven Central deployment

Co-authored-by: kaikreuzer <3244965+kaikreuzer@users.noreply.github.com>

* Remove unused output from maven-deploy step

Co-authored-by: kaikreuzer <3244965+kaikreuzer@users.noreply.github.com>

---------

Signed-off-by: Kai Kreuzer <kai@openhab.org>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: kaikreuzer <3244965+kaikreuzer@users.noreply.github.com>
Co-authored-by: Kai Kreuzer <kai@openhab.org>
kaikreuzer added a commit that referenced this pull request Dec 6, 2025
…se workflow (#528)

* Initial plan

* Add explicit fail-fast behavior for Maven Central deployment

Co-authored-by: kaikreuzer <3244965+kaikreuzer@users.noreply.github.com>

* Remove unused output from maven-deploy step

Co-authored-by: kaikreuzer <3244965+kaikreuzer@users.noreply.github.com>

---------

Signed-off-by: Kai Kreuzer <kai@openhab.org>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: kaikreuzer <3244965+kaikreuzer@users.noreply.github.com>
Co-authored-by: Kai Kreuzer <kai@openhab.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants