Skip to content

Conversation

Copy link

Copilot AI commented Dec 5, 2025

Addresses feedback from #497 about duplicated POM file lists making maintenance difficult.

Changes

  • Parent POM version update (snapshot): Use find command instead of hardcoded list, consistent with release version step
  • Git staging: Replace 8 explicit git add commands with git add **/pom.xml glob pattern in both commit steps

Before/After

# Before - duplicated in 4 places
for pom in custom-checks/pom.xml custom-checks/checkstyle/pom.xml custom-checks/findbugs/pom.xml ...; do
git add custom-checks/pom.xml
git add custom-checks/checkstyle/pom.xml
# ... 6 more lines

# After - single source of truth
for pom in $(find custom-checks sat-extension sat-plugin codestyle -name pom.xml); do
git add **/pom.xml

New modules are now automatically discovered.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: kaikreuzer <3244965+kaikreuzer@users.noreply.github.com>
Copilot AI changed the title [WIP] Update implementation based on feedback for release process Fix duplicated POM file lists in release workflow Dec 5, 2025
Copilot AI requested a review from kaikreuzer December 5, 2025 16:10
@kaikreuzer kaikreuzer marked this pull request as ready for review December 5, 2025 16:10
@kaikreuzer kaikreuzer requested a review from a team as a code owner December 5, 2025 16:10
@kaikreuzer kaikreuzer merged commit 3ba7aba into release Dec 5, 2025
1 check passed
@kaikreuzer kaikreuzer deleted the copilot/sub-pr-497-again branch December 5, 2025 16:11
holgerfriedrich pushed a commit to holgerfriedrich/static-code-analysis that referenced this pull request Dec 6, 2025
* Initial plan

* Fix duplicated POM file lists: use find command and glob patterns

Co-authored-by: kaikreuzer <3244965+kaikreuzer@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: kaikreuzer <3244965+kaikreuzer@users.noreply.github.com>
kaikreuzer added a commit that referenced this pull request Dec 6, 2025
* Initial plan

* Fix duplicated POM file lists: use find command and glob patterns

Co-authored-by: kaikreuzer <3244965+kaikreuzer@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: kaikreuzer <3244965+kaikreuzer@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants