-
Notifications
You must be signed in to change notification settings - Fork 33
docs: remove fga_client.close() from README (#191) #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe README.md was updated to remove redundant explicit Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Pre-merge checks and finishing touches✅ Passed checks (5 passed)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
Removes the unnecessary
fga_client.close()call from the README example.What problem is being solved?
The example included a
.close()call, but the Python SDK automatically handles client closing via context managers, so users don't need to call it manually.How is it being solved?
By removing the redundant line from the README documentation.
What changes are made to solve it?
References
Closes #191
Review Checklist
main)🟣 Hacktoberfest
This PR is part of Hacktoberfest 2025 🎃.
If valid, please mark it as
hacktoberfest-accepted. Thank you!Summary by CodeRabbit