Skip to content

Implement filtering logic for min_severity and trace_based parameters #4765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rads-1996 wants to merge 36 commits into
base: main
Choose a base branch
from
Open

Implement filtering logic for min_severity and trace_based parameters #4765

rads-1996 wants to merge 36 commits into from

Conversation

@rads-1996
Copy link
Contributor

@rads-1996 rads-1996 commented Oct 6, 2025 •
edited
Loading

Description

Implement Spec to filter logs based on min_severity and trace_based parameters.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added unit tests

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@rads-1996 rads-1996 requested a review from a team as a code owner October 6, 2025 22:10
@rads-1996 rads-1996 force-pushed the trace-based-sampling branch from 3557ca9 to fa903d0 Compare October 7, 2025 16:01
@xrmx xrmx moved this to Ready for review in @xrmx's Python PR digest Oct 9, 2025
@rads-1996 rads-1996 force-pushed the trace-based-sampling branch from e61189d to 4f3ee75 Compare October 20, 2025 18:11
@rads-1996 rads-1996 force-pushed the trace-based-sampling branch from c209824 to 6bef931 Compare November 5, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aabmass aabmass aabmass left review comments

@lzchen lzchen lzchen left review comments

+1 more reviewer

@hectorhdzg hectorhdzg hectorhdzg left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

@xrmx's Python PR digest
Status: Ready for review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rads-1996 @aabmass @lzchen @hectorhdzg