refactor: simplify evaluation context updates for before hooks #1257
+40
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove redundant loop for updating the hook contexts - Add simple test case to make sure the same object reference is being updated Signed-off-by: Marko Mlakar <markomlakar2@gmail.com>
aepfli
approved these changes
Nov 21, 2025
Member
aepfli
left a comment
aepfli
left a comment
There was a problem hiding this comment.
thank you this looks good to me - but i am by far not a js expert, maybe somebody else can have a look at this
guidobrei
reviewed
Dec 9, 2025
| const hookContext = hookContexts[hookContextIndex]; | ||
|
|
||
| // Update the context on the stable hook context object | ||
| Object.assign(hookContext.context, accumulatedContext); |
Member
There was a problem hiding this comment.
If we remove this line, the accumulatedContext is not available in the beforeHook on the next line.
Author
There was a problem hiding this comment.
Thanks @guidobrei you are correct. I have updated the PR
Signed-off-by: markomlakar <marko.mlakar@dynatrace.com>
* Reverted the purposed changes to ensure the before hook gets the accumulated hook context * Replaced the for loop with a single shared object update Signed-off-by: MarkoMlakar <marko.mlakar@dynatrace.com>
MarkoMlakar
commented
Dec 11, 2025
| Object.assign(accumulatedContext, hookResult); | ||
|
|
||
| for (let i = 0; i < hooks.length; i++) { | ||
| Object.assign(hookContexts[hookContextIndex].context, accumulatedContext); |
Author
There was a problem hiding this comment.
hookContext.context is a shared object. All the hooks recieve and operate on the same context object, making this for loop redundant
Member
There was a problem hiding this comment.
Is it? from the method signature it could be different contexts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
#1236
Notes
The accumulated evaluation context object is shared with all the hooks (same object reference). This makes the inner for loop for updating the contexts redundant
How to test
npm run test