Improve unblob "skip-extraction" mode of operation #692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense and looks good! 👍 |
e3krisztian
reviewed
Jan 2, 2024
Contributor
e3krisztian
left a comment
e3krisztian
left a comment
There was a problem hiding this comment.
I thinks this is fine as is (only code reordering proposed), however there is no test for skip_extraction at all, so future changes could inadvertently break the newly added functionality.
qkaiser
force-pushed
the
ui-no-extract-report
branch
from
8a0df96 to
2895922
Compare
Contributor
Author
|
@e3krisztian I applied your recommendations, introduced tests for both the cli and processing parts of |
…aunched with --skip-extraction.
Co-authored-by: Krisztián Fekete <1246751+e3krisztian@users.noreply.github.com>
qkaiser
force-pushed
the
ui-no-extract-report
branch
from
2895922 to
d1b6ccc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following improvements have been made in order to let user simply "scan" a file:
--skip-extractionoption.--skip-extractionoption.This is related to #624.
Right now the information displayed to the user is fairly limited:
But the introduction of metadata reporting in chunks (see #557) would allow us to display detailed information in the "description" column, such as endianness, version, compression, block size, creation size, etc.