Allow Shopify pagination header Link to be seen
#5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the header contains multiple colons the function strips the value ex: with shopify's pagination on their products api `/admin/api/2019-10/products.json` they include the link to the next page in their header `Link` this link includes `https://` which the current function will slice and remove the entire link leaving only `https`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the header contains multiple colons the function strips the value
ex: with shopify's pagination on their products api
/admin/api/2019-10/products.jsonthey include the link to the next page in their headerLinkthis link includeshttps://<shopname>?page_keywhich the current function will slice and remove the entire link leaving onlyhttpsmaking this function unable to call the next pagination page