Fix ExecuteScriptEnhanced #83
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a script calls a ScriptParameter-related function (ClearScriptParams, AddScriptParametersXXX, or ExecuteScriptEnhanced with bClearParams = true), the game tries to inspect the parameters buffer, delete all parameters in it, and free the buffer.
Currently, if a script called by our internal ExecuteScriptEnhanced uses one of those functions, the game crashes because NWN2 cannot manage the std::vector memory used.
The changes here:
This fixes crashes when scripts use parameter management functions within ExecuteScriptEnhanced.