Skip to content

Conversation

@dhurley
Copy link
Collaborator

@dhurley dhurley commented Nov 17, 2025

Proposed changes

Ensure in progress requests are processed before resetting the gRPC connection with the management plane.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@dhurley dhurley self-assigned this Nov 17, 2025
@github-actions github-actions bot added the chore Pull requests for routine tasks label Nov 17, 2025
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

❌ Patch coverage is 90.47619% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.25%. Comparing base (e2ad230) to head (b37a0b8).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/command/command_plugin.go 50.00% 2 Missing and 1 partial ⚠️
internal/command/command_service.go 91.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1391      +/-   ##
==========================================
+ Coverage   85.17%   85.25%   +0.08%     
==========================================
  Files         102      102              
  Lines       12928    12972      +44     
==========================================
+ Hits        11011    11059      +48     
+ Misses       1433     1426       -7     
- Partials      484      487       +3     
Files with missing lines Coverage Δ
internal/config/config.go 87.44% <100.00%> (+0.06%) ⬆️
internal/config/defaults.go 100.00% <ø> (ø)
internal/config/flags.go 100.00% <ø> (ø)
internal/config/types.go 87.65% <ø> (ø)
...ternal/resource/nginx_instance_process_operator.go 61.76% <100.00%> (ø)
internal/watcher/instance/nginx_process_parser.go 91.66% <100.00%> (+0.89%) ⬆️
internal/command/command_plugin.go 73.79% <50.00%> (ø)
internal/command/command_service.go 79.82% <91.66%> (+0.56%) ⬆️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2ad230...b37a0b8. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dhurley dhurley marked this pull request as ready for review November 19, 2025 15:51
@dhurley dhurley requested a review from a team as a code owner November 19, 2025 15:51
Copy link
Contributor

@sean-breen sean-breen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some tests around the case where len(cs.requestsInProgress) > 0?

@dhurley dhurley changed the title Ensure in progress requests are processed before resetting the gRPC connection with the management plane Draft: Ensure in progress requests are processed before resetting the gRPC connection with the management plane Nov 27, 2025
@dhurley dhurley changed the title Draft: Ensure in progress requests are processed before resetting the gRPC connection with the management plane Ensure in progress requests are processed before resetting the gRPC connection with the management plane Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants