-
Notifications
You must be signed in to change notification settings - Fork 102
Ensure in progress requests are processed before resetting the gRPC connection with the management plane #1391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…onnection with the management plane
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1391 +/- ##
==========================================
+ Coverage 85.17% 85.25% +0.08%
==========================================
Files 102 102
Lines 12928 12972 +44
==========================================
+ Hits 11011 11059 +48
+ Misses 1433 1426 -7
- Partials 484 487 +3
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
sean-breen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add some tests around the case where len(cs.requestsInProgress) > 0?
… master processes
Proposed changes
Ensure in progress requests are processed before resetting the gRPC connection with the management plane.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)