feat: return detected framework version accuracy #6852
+157
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhalp
commented
Dec 18, 2025
| private async npmDependenciesUsed( | ||
| pkgJSON: Partial<PackageJson>, | ||
| ): Promise<{ name: string; version?: SemVer } | undefined> { | ||
| const allDeps = [...Object.entries(pkgJSON.dependencies || {}), ...Object.entries(pkgJSON.devDependencies || {})] |
Member
Author
There was a problem hiding this comment.
I couldn't help myself here. This was unnecessarily complicated. Instead of just merging two record objects, we were turning them into an array [[k1, v1], [k2, v2], ...] for some reason, which is less readable, more complicated, and presumably less performant (we use .find() on this, twice).
pieh
reviewed
Dec 18, 2025
pieh
reviewed
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@netlify/build-infocurrently uses two mechanisms for detecting a detected framework's version: a high-fidelity check of the installed package innode_modulesand a low-fidelity fallback check based on the version range inpackage.jsondependencies. It does this automatically and opaquely.Much like the existing framework accuracy, this PR adds a framework version accuracy field on the result, for improved transparency.