-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Upgrade @angular/common from 12.0.4 to 12.2.17 #654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Snyk has created this PR to upgrade @angular/common from 12.0.4 to 12.2.17. See this package in npm: @angular/common See this project in Snyk: https://app.snyk.io/org/mohammadnewton/project/62ca605f-5f4e-444b-a866-1857eb3a59a6?utm_source=github&utm_medium=referral&page=upgrade-pr
Summary of ChangesHello @nejidevelops, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, aims to adjust the version of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, generated by Snyk, introduces a critical issue by downgrading the @angular/common package to version 12 while other core Angular packages are on version 15. This version mismatch will likely break the application, as all @angular/* packages should be on the same major version for compatibility. This pull request should be rejected.
| "dependencies": { | ||
| "@angular/animations": "^15.0.0", | ||
| "@angular/common": "^15.0.0", | ||
| "@angular/common": "^12.2.17", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change downgrades @angular/common from ^15.0.0 to ^12.2.17. This introduces a critical version mismatch, as other core Angular packages like @angular/core and @angular/compiler are on version ^15.0.0. All @angular/* packages should be on the same major version to ensure compatibility and prevent build or runtime errors. This change should be reverted.
| "@angular/common": "^12.2.17", | |
| "@angular/common": "^15.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "@angular/animations": "^15.0.0", | ||
| "@angular/common": "^15.0.0", | ||
| "@angular/common": "^12.2.17", | ||
| "@angular/compiler": "^15.0.0", | ||
| "@angular/core": "^15.0.0", | ||
| "@angular/forms": "^15.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep Angular framework packages on matching major versions
The change lowers @angular/common to ^12.2.17 while the rest of the Angular framework packages (@angular/core, @angular/compiler, CLI, etc.) stay on ^15.0.0. Angular libraries declare strict peer dependencies on the same major version; installing or building with one package on v12 and others on v15 fails with peer-dependency resolution errors and prevents the app from compiling. If this upgrade is needed, all Angular packages should be aligned to the same major release.
Useful? React with 👍 / 👎.
Snyk has created this PR to upgrade @angular/common from 12.0.4 to 12.2.17.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 36 versions ahead of your current version.
The recommended version was released 3 years ago.
Release notes
Package name: @angular/common
-
12.2.17 - 2022-11-22
-
12.2.16 - 2022-01-27
-
12.2.15 - 2021-12-15
-
12.2.14 - 2021-12-01
-
12.2.13 - 2021-11-03
-
12.2.12 - 2021-10-27
-
12.2.11 - 2021-10-20
-
12.2.10 - 2021-10-13
-
12.2.9 - 2021-10-06
-
12.2.8 - 2021-09-30
-
12.2.7 - 2021-09-22
-
12.2.6 - 2021-09-15
-
12.2.5 - 2021-09-08
-
12.2.4 - 2021-09-01
-
12.2.3 - 2021-08-25
-
12.2.2 - 2021-08-18
-
12.2.1 - 2021-08-11
-
12.2.0 - 2021-08-04
-
12.2.0-rc.0 - 2021-07-28
-
12.2.0-next.3 - 2021-07-21
-
12.2.0-next.2 - 2021-07-14
-
12.2.0-next.1 - 2021-06-30
-
12.2.0-next.0 - 2021-06-24
-
12.1.5 - 2021-08-04
-
12.1.4 - 2021-07-28
-
12.1.3 - 2021-07-21
-
12.1.2 - 2021-07-14
-
12.1.1 - 2021-06-30
-
12.1.0 - 2021-06-24
-
12.1.0-next.6 - 2021-06-17
-
12.1.0-next.5 - 2021-06-09
-
12.1.0-next.4 - 2021-06-02
-
12.1.0-next.3 - 2021-05-26
-
12.1.0-next.2 - 2021-05-19
-
12.1.0-next.1 - 2021-05-05
-
12.0.5 - 2021-06-16
-
12.0.4 - 2021-06-09
from @angular/common GitHub release notesImportant
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information: