fix: Prevent conflicting provisioning requests #1025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabehamilton
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On fresh startup, all provisioning requests will be sent simultaneously. This creates problems when multiple requests for the same account are actioned in quick succession - both will attempt to create a virtual DB at the same time causing only one to succeed. The main driver for this is to make local development, especially on fresh install, less problematic.
This PR contains a simple fix to rate limit the provisioning requests from Coordinator to reduce the overlap between provisioning attempts, avoiding the problem described above. This does also rate limit get requests but they are infrequent so this shouldn't pose a problem.