Skip to content

[menu] Avoid disabling modality on click after hover-open #3455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
atomiks wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[menu] Avoid disabling modality on click after hover-open #3455

atomiks wants to merge 2 commits into from

Conversation

@atomiks
Copy link
Contributor

@atomiks atomiks commented Dec 7, 2025 •
edited
Loading

Fixes a bug when a menu is opened on hover, and is then clicked to "stick": the modal prop would incorrectly be ignored

@atomiks atomiks added component: menu Changes related to the menu component. type: bug It doesn't behave as expected. component: popover Changes related to the popover component. labels Dec 7, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 7, 2025 •
edited
Loading

  • vite-css-base-ui-example

    pnpm add https://pkg.pr.new/mui/base-ui/@base-ui/react@3455

    pnpm add https://pkg.pr.new/mui/base-ui/@base-ui/utils@3455

commit: 5ceeb4c

@mui-bot
Copy link

mui-bot commented Dec 7, 2025 •
edited
Loading

Bundle size report

Bundle Parsed size Gzip size
@base-ui/react 🔺+8B(0.00%) 🔺+1B(0.00%)

Details of bundle changes

Check out the code infra dashboard for more information about this PR.

@netlify
Copy link

netlify bot commented Dec 7, 2025 •
edited
Loading

✅ Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 5ceeb4c
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/693a07d08c0b780008de3a9f
😎 Deploy Preview https://deploy-preview-3455--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@atomiks atomiks force-pushed the fix/menu-popover-modal branch from aa38e60 to 1984235 Compare December 7, 2025 11:50
@atomiks atomiks marked this pull request as ready for review December 7, 2025 23:55
@michaldudak
Copy link
Member

michaldudak commented Dec 9, 2025

Opening on hover doesn't work reliably now with modal=true. Also, the flashing sidebar when hovering over triggers is quite annoying.

Screen.Recording.2025-12-09.at.10.16.06.mov

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Dec 10, 2025
@atomiks atomiks force-pushed the fix/menu-popover-modal branch from b2266d4 to 2f726ad Compare December 10, 2025 23:35
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Dec 10, 2025
@atomiks atomiks changed the title [menu][popover] Avoid disabling modality with hover opens [menu][popover] Avoid disabling modality on click after hover-open Dec 10, 2025
@atomiks atomiks force-pushed the fix/menu-popover-modal branch 2 times, most recently from c315ac5 to 905d0c1 Compare December 10, 2025 23:42
@atomiks atomiks changed the title [menu][popover] Avoid disabling modality on click after hover-open [menu] Avoid disabling modality on click after hover-open Dec 10, 2025
@atomiks atomiks removed the component: popover Changes related to the popover component. label Dec 10, 2025
@atomiks atomiks force-pushed the fix/menu-popover-modal branch from 905d0c1 to 5ceeb4c Compare December 10, 2025 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colmtuite colmtuite Awaiting requested review from colmtuite colmtuite is a code owner

@michaldudak michaldudak Awaiting requested review from michaldudak michaldudak is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

component: menu Changes related to the menu component. type: bug It doesn't behave as expected.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@atomiks @mui-bot @michaldudak