[combobox][select] Respect itemToStringValue for onFormSubmit
#3441
+178
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomiks
added
component: select
commit: |
Bundle size report
Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
LukasTy
approved these changes
Dec 5, 2025
Member
LukasTy
left a comment
LukasTy
left a comment
There was a problem hiding this comment.
Makes sense. 👍
Even though there might be cases where having the full object could be useful, those should be a minority. 👌
| controlRef, | ||
| name, | ||
| getValue: () => value, | ||
| getValue: () => fieldStringValue, |
Member
There was a problem hiding this comment.
Since we only use fieldStringValue inside this callback, does it make sense to compute it lazily?
Or is it used frequently enough to always compute it in the render?
Contributor
Author
There was a problem hiding this comment.
value/getValue are distinct for the useField hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes object values with
<Form onFormSubmit>passing the plain object instead of the stringified form value