Moved some fields from the GlobalCtx to a new class, _UpdateCtx #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lets us swiftly remove all dag run-related state once it is done Ban .listen even for async computations onDependencyUpdated no longer throws exceptions NoValueException Instead returns an empty downstream .listen no longer calls eval() directly It used to bypass onDependencyChanged, breaking the delayed eval pattern Routers: Delay the delivery of data if a dag run is already going on StreamExtension: Delay the onListen event by one microtask to make sure we don't call .listen within a computation in case we are being used by a computation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #44 +/- ##
==========================================
- Coverage 99.60% 99.39% -0.22%
==========================================
Files 42 42
Lines 1794 1811 +17
Branches 971 976 +5
==========================================
+ Hits 1787 1800 +13
- Misses 7 11 +4
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets us swiftly remove all dag run-related state once it is done
Ban .listen even for async computations
onDependencyUpdated no longer throws exceptions NoValueException
Instead returns an empty downstream
.listen no longer calls eval() directly
It used to bypass onDependencyChanged, breaking the delayed eval pattern
Routers: Delay the delivery of data if a dag run is already going on StreamExtension: Delay the onListen event by one microtask to make sure we don't call .listen within a computation in case we are being used by a computation