BasicSelect filtered customAttrs fix #118
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating Basic Select to use filterOptions instead of options when checking customAttrs. This stops the issue where when searching, incorrect attrs get assigned based on the original options array, instead of the filteredOptions subset
ModelSelect also now has references to filteredOptions instead of options for customAttrs fix when searching
|
up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #117
Updating Basic Select to use filterOptions instead of options when checking customAttrs. This stops the issue where when searching, incorrect attrs get assigned based on the original options array, instead of the filteredOptions subset
EDIT:: also updating ModelSelect to have this fix